marco/i3status
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Initialize fields with zero bytes in wireless module

Browse Source 
Previously, the fields in the wireless module were declared but not explicitly
initialized upon declaration. As nothing else would do so afterwards, this
could introduce random characters left over in the memory segment into
the fields. This was explicitly observed in the essid-field, but likely
a possibility for other fields as well. Hence, this commit adds explicit
initialization with zero bytes to all fields to ensure proper
termination of all fields.

Fixes #432
This commit is contained in:
Jonas Große Sundrup 2020-10-09 12:08:34 +02:00
parent 3451a0d9fc
commit afc73e1982
No known key found for this signature in database
GPG Key ID: 5B587ADC0531D442
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/print_wireless_info.c
View File

@ -554,13 +554,13 @@ void print_wireless_info(yajl_gen json_gen, char *buffer, const char *interface,
} }
} }
char string_quality[STRING_SIZE]; char string_quality[STRING_SIZE] = {'\0'};
char string_signal[STRING_SIZE]; char string_signal[STRING_SIZE] = {'\0'};
char string_noise[STRING_SIZE]; char string_noise[STRING_SIZE] = {'\0'};
char string_essid[STRING_SIZE]; char string_essid[STRING_SIZE] = {'\0'};
char string_frequency[STRING_SIZE]; char string_frequency[STRING_SIZE] = {'\0'};
char string_ip[STRING_SIZE]; char string_ip[STRING_SIZE] = {'\0'};
char string_bitrate[STRING_SIZE]; char string_bitrate[STRING_SIZE] = {'\0'};
if (info.flags & WIRELESS_INFO_FLAG_HAS_QUALITY) { if (info.flags & WIRELESS_INFO_FLAG_HAS_QUALITY) {
if (info.quality_max) if (info.quality_max)