revert back to using nanosleep

Fixes #93
This commit is contained in:
Watcom Hecht 2016-01-12 11:35:02 -02:00
parent fad9c8237c
commit dd75c260f8
4 changed files with 14 additions and 26 deletions

View File

@ -23,6 +23,7 @@ LIBS+=-lconfuse
LIBS+=-lyajl LIBS+=-lyajl
LIBS+=-lpulse LIBS+=-lpulse
LIBS+=-lm LIBS+=-lm
LIBS+=-lpthread
VERSION:=$(shell git describe --tags --abbrev=0) VERSION:=$(shell git describe --tags --abbrev=0)
GIT_VERSION:="$(shell git describe --tags --always) ($(shell git log --pretty=format:%cd --date=short -n1))" GIT_VERSION:="$(shell git describe --tags --always) ($(shell git log --pretty=format:%cd --date=short -n1))"
@ -72,7 +73,7 @@ OBJS:=$(OBJS:.c=.o)
ifeq ($(OS),OpenBSD) ifeq ($(OS),OpenBSD)
OBJS:=$(filter-out src/pulse.o, $(OBJS)) OBJS:=$(filter-out src/pulse.o, $(OBJS))
LIBS:=$(filter-out -lpulse, $(LIBS)) -lpthread LIBS:=$(filter-out -lpulse, $(LIBS))
endif endif
src/%.o: src/%.c include/i3status.h src/%.o: src/%.c include/i3status.h

View File

@ -62,8 +62,7 @@ cfg_t *cfg, *cfg_general, *cfg_section;
void **cur_instance; void **cur_instance;
pthread_cond_t i3status_sleep_cond = PTHREAD_COND_INITIALIZER; pthread_t main_thread;
pthread_mutex_t i3status_sleep_mutex = PTHREAD_MUTEX_INITIALIZER;
/* /*
* Set the exit_upon_signal flag, because one cannot do anything in a safe * Set the exit_upon_signal flag, because one cannot do anything in a safe
@ -82,7 +81,6 @@ void fatalsig(int signum) {
* *
*/ */
void sigusr1(int signum) { void sigusr1(int signum) {
pthread_cond_broadcast(&i3status_sleep_cond);
} }
/* /*
@ -453,6 +451,7 @@ int main(int argc, char *argv[]) {
struct sigaction action; struct sigaction action;
memset(&action, 0, sizeof(struct sigaction)); memset(&action, 0, sizeof(struct sigaction));
action.sa_handler = fatalsig; action.sa_handler = fatalsig;
main_thread = pthread_self();
/* Exit upon SIGPIPE because when we have nowhere to write to, gathering system /* Exit upon SIGPIPE because when we have nowhere to write to, gathering system
* information is pointless. Also exit explicitly on SIGTERM and SIGINT because * information is pointless. Also exit explicitly on SIGTERM and SIGINT because
@ -578,7 +577,6 @@ int main(int argc, char *argv[]) {
char buffer[4096]; char buffer[4096];
void **per_instance = calloc(cfg_size(cfg, "order"), sizeof(*per_instance)); void **per_instance = calloc(cfg_size(cfg, "order"), sizeof(*per_instance));
pthread_mutex_lock(&i3status_sleep_mutex);
while (1) { while (1) {
if (exit_upon_signal) { if (exit_upon_signal) {
@ -714,21 +712,13 @@ int main(int argc, char *argv[]) {
fflush(stdout); fflush(stdout);
/* To provide updates on every full second (as good as possible) /* To provide updates on every full second (as good as possible)
* we dont use sleep(interval) but we sleep until the next second. * we dont use sleep(interval) but we sleep until the next
* We also align to 60 seconds modulo interval such * second (with microsecond precision) plus (interval-1)
* seconds. We also align to 60 seconds modulo interval such
* that we start with :00 on every new minute. */ * that we start with :00 on every new minute. */
struct timespec ts; struct timeval current_timeval;
#if defined(__APPLE__) gettimeofday(&current_timeval, NULL);
gettimeofday(&tv, NULL); struct timespec ts = {interval - 1 - (current_timeval.tv_sec % interval), (10e5 - current_timeval.tv_usec) * 1000};
ts.tv_sec = tv.tv_sec; nanosleep(&ts, NULL);
#else
clock_gettime(CLOCK_REALTIME, &ts);
#endif
ts.tv_sec += interval - (ts.tv_sec % interval);
ts.tv_nsec = 0;
/* Sleep to absolute time 'ts', unless the condition
* 'i3status_sleep_cond' is signaled from another thread */
pthread_cond_timedwait(&i3status_sleep_cond, &i3status_sleep_mutex, &ts);
} }
} }

View File

@ -222,7 +222,5 @@ extern cfg_t *cfg, *cfg_general, *cfg_section;
extern void **cur_instance; extern void **cur_instance;
extern pthread_cond_t i3status_sleep_cond; extern pthread_t main_thread;
extern pthread_mutex_t i3status_sleep_mutex;
#endif #endif

View File

@ -2,6 +2,7 @@
#include <string.h> #include <string.h>
#include <stdio.h> #include <stdio.h>
#include <math.h> #include <math.h>
#include <signal.h>
#include <pulse/pulseaudio.h> #include <pulse/pulseaudio.h>
#include "i3status.h" #include "i3status.h"
#include "queue.h" #include "queue.h"
@ -89,9 +90,7 @@ static void store_volume_from_sink_cb(pa_context *c,
save_volume(DEFAULT_SINK_INDEX, composed_volume)) | save_volume(DEFAULT_SINK_INDEX, composed_volume)) |
save_volume(info->index, composed_volume)) { save_volume(info->index, composed_volume)) {
/* if the volume or mute flag changed, wake the main thread */ /* if the volume or mute flag changed, wake the main thread */
pthread_mutex_lock(&i3status_sleep_mutex); pthread_kill(main_thread, SIGUSR1);
pthread_cond_broadcast(&i3status_sleep_cond);
pthread_mutex_unlock(&i3status_sleep_mutex);
} }
} }