marco/mchess-client
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix green flicker of squares on invalid move #1

Merged
marco merged 1 commits from fix-green-square-flicker into master 2023-08-25 10:39:08 +00:00
Conversation 1 Commits 1 Files Changed 2 +13 -11
marco commented 2023-08-25 10:36:37 +00:00
Owner
Copy Link

With this PR, the flickering of the squares are fixed.

The flickering happened because we colored them green on the player's move.
If it was an invalid move, the server responded with the old position (after a couple of frames), and the squares were colored normal again.

With this PR, the flickering of the squares are fixed. The flickering happened because we colored them green on the player's move. If it was an invalid move, the server responded with the old position (after a couple of frames), and the squares were colored normal again.
marco added 1 commit 2023-08-25 10:36:37 +00:00
marco self-assigned this 2023-08-25 10:37:18 +00:00
marco commented 2023-08-25 10:39:01 +00:00
Author
Owner
Copy Link

Worst code I've ever seen. Accepted.

Worst code I've ever seen. Accepted.
marco merged commit 102c0de20d into master 2023-08-25 10:39:08 +00:00
marco deleted branch fix-green-square-flicker 2023-08-25 10:39:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
marco
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: marco/mchess-client#1
No description provided.
Delete Branch "fix-green-square-flicker"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?