marco
/
mchess-client
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix tapping on opponent's piece #8

Merged
marco merged 1 commits from fix-tap-on-drag into master 2024-02-01 10:42:19 +00:00
Conversation 0 Commits 1 Files Changed 5 +14 -10
marco commented 2024-02-01 10:39:50 +00:00
Owner
Copy Link

With the previous change of starting a tap on a drag,
we removed the GestureDetector from all squares with any pieces.

This included the opponent's pieces. Tapping and taking an opponent's
piece was not possible anymore.

This was a bug, since we still want to detect a tap and take an opponent's piece.

With the previous change of starting a tap on a drag, we removed the GestureDetector from all squares with any pieces. This included the opponent's pieces. Tapping and taking an opponent's piece was not possible anymore. This was a bug, since we still want to detect a tap and take an opponent's piece.
marco added 1 commit 2024-02-01 10:39:51 +00:00
200393ac76 Fix tapping on opponent's piece 
With the previous change of starting a tap on a drag,
we removed the GestureDetector from all squares with any pieces.

This included the opponent's pieces. Tapping and taking an opponent's
piece was not possible anymore.

This was a bug, since we still want to detect a tap and take an opponent's piece.
marco merged commit 33e79a90c9 into master 2024-02-01 10:42:19 +00:00
marco deleted branch fix-tap-on-drag 2024-02-01 10:47:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: marco/mchess-client#8
No description provided.
Delete Branch "fix-tap-on-drag"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?