marco
/
mchess-server
1
0
Fork 0
Code Issues 5 Pull Requests Packages Projects Releases Wiki Activity

Fix a bug that allowed castling even if squares were attacked #3

Merged
marco merged 1 commits from castling-through-check into master 2024-04-09 19:55:40 +00:00
Conversation 0 Commits 1 Files Changed 7 +252 -63
marco commented 2024-04-09 19:50:27 +00:00
Owner
Copy Link
No description provided.
marco added 1 commit 2024-04-09 19:50:28 +00:00
marco reviewed 2024-04-09 19:51:45 +00:00
chess/king.go
@ -69,3 +67,3 @@
)
func (k King) movedOnValidCastlingSquare(b *Board, move types.Move) (bool, CastlingDirection) {
func (k King) isCastlingAllowed(b *Board, move types.Move) (bool, CastlingDirection) {
marco commented 2024-04-09 19:51:45 +00:00
Author
Owner
Copy Link

This function is just ugly.
It checks a lot of things. The code for the black and white branches are almost the same. This should be done in multiple steps in a more systematic fashion.

This function is just ugly. It checks a lot of things. The code for the black and white branches are almost the same. This should be done in multiple steps in a more systematic fashion.
marco merged commit 4153f4cc7c into master 2024-04-09 19:55:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: marco/mchess-server#3
No description provided.
Delete Branch "castling-through-check"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?